search

sdboyer / gps

your dependencies have arrived
MIT License
270 stars 24 forks source link

#172 change analyzer version to int #190

Closed chx closed 7 years ago

codecov[bot] commented 7 years ago

Codecov Report

Merging #190 into master will decrease coverage by 0.34%. The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master    #190      +/-   ##
=========================================
- Coverage   79.54%   79.2%   -0.35%     
=========================================
  Files          24      24              
  Lines        3804    3804              
=========================================
- Hits         3026    3013      -13     
- Misses        584     595      +11     
- Partials      194     196       +2
Impacted Files Coverage Δ
source_manager.go 92.13% <0%> (ø) :white_check_mark:
bridge.go 76.16% <100%> (ø) :white_check_mark:
hash.go 81.35% <100%> (ø) :white_check_mark:
analysis.go 86.49% <0%> (-3.38%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7447ec8...e9030b6. Read the comment docs.

codecov[bot] commented 7 years ago

Codecov Report

Merging #190 into master will decrease coverage by 0.34%. The diff coverage is 66.66%.

@@            Coverage Diff            @@
##           master    #190      +/-   ##
=========================================
- Coverage   79.54%   79.2%   -0.35%     
=========================================
  Files          24      24              
  Lines        3804    3804              
=========================================
- Hits         3026    3013      -13     
- Misses        584     595      +11     
- Partials      194     196       +2
Impacted Files Coverage Δ
source_manager.go 92.13% <0%> (ø) :white_check_mark:
bridge.go 76.16% <100%> (ø) :white_check_mark:
hash.go 81.35% <100%> (ø) :white_check_mark:
analysis.go 86.49% <0%> (-3.38%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7447ec8...eaf84ad. Read the comment docs.

sdboyer commented 7 years ago

Awesome. thank you!

sdboyer commented 7 years ago

Ohh, yeah, there's this one tricksy thing - example.go also needs to be updated. It's easy to miss, because it's not touched by any tests.

You can just go build example.go to test and see whether it builds. That's the only check the CI system is running.