search

sdboyer / gps

your dependencies have arrived
MIT License
270 stars 24 forks source link

Add Release() to the SourceManager interface #206

Closed spenczar closed 7 years ago

spenczar commented 7 years ago

This is already being used by dep. We discussed it a little bit in https://github.com/golang/dep/pull/353.

codecov[bot] commented 7 years ago

Codecov Report

Merging #206 into master will increase coverage by 0.32%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #206      +/-   ##
=========================================
+ Coverage   77.98%   78.3%   +0.32%     
=========================================
  Files          28      28              
  Lines        4020    4020              
=========================================
+ Hits         3135    3148      +13     
+ Misses        660     650      -10     
+ Partials      225     222       -3
Impacted Files Coverage Δ
bridge.go 75.91% <ø> (ø) :arrow_up:
source_manager.go 90.35% <ø> (ø) :arrow_up:
deduce.go 76.49% <0%> (ø) :arrow_up:
pkgtree/pkgtree.go 85.07% <0%> (+3.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6db8155...c240c2a. Read the comment docs.

sdboyer commented 7 years ago

......wat? (at the appveyor failure)

spenczar commented 7 years ago

It must be testing a merge commit that it made which includes #196, or something? That's all I can think of... maybe I'll merge master down into my branch.

spenczar commented 7 years ago

Yep, that's what it is. Will fix.

sdboyer commented 7 years ago

Oh, wait, right, because CircleCI is just testing the PR branch, not the merged result. smh...

sdboyer commented 7 years ago

Thanks!