Closed sdboyer closed 7 years ago
An enterprising soul could probably figure this one out and update this issue with a suggestion about where the problem is 😄
The goal within the test harness - in depspecSourceManager.ListVersions()
- is to produce those paired versions with an underlying FAKEREV
only if necessary to meet the interface requirement, and then strip them out immediately in depspecBridge.listVersions()
. The latter is the only thing the solver should be calling...I think. Somehow, though, FAKEREV
s are making it through into the solutions. The task here is to figure out where that leak is.
Merging #210 into master will decrease coverage by
3.18%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 78.02% 74.83% -3.19%
==========================================
Files 28 4 -24
Lines 4018 465 -3553
==========================================
- Hits 3135 348 -2787
+ Misses 659 95 -564
+ Partials 224 22 -202
Impacted Files | Coverage Δ | |
---|---|---|
selection.go | ||
source_cache.go | ||
deduce.go | ||
rootdata.go | ||
maybe_source.go | ||
cmd.go | ||
vcs_source.go | ||
constraints.go | ||
trace.go | ||
manifest.go | ||
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c7c4309...a9b5817. Read the comment docs.
Merging #210 into master will increase coverage by
0.39%
. The diff coverage is96.79%
.
@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 79.01% 79.41% +0.39%
==========================================
Files 30 31 +1
Lines 4175 4143 -32
==========================================
- Hits 3299 3290 -9
+ Misses 649 624 -25
- Partials 227 229 +2
Impacted Files | Coverage Δ | |
---|---|---|
satisfy.go | 80.92% <100%> (ø) |
:arrow_up: |
version.go | 82.36% <100%> (+3.29%) |
:arrow_up: |
solver.go | 83.97% <100%> (+0.09%) |
:arrow_up: |
bridge.go | 65.38% <100%> (-10.54%) |
:arrow_down: |
version_queue.go | 100% <100%> (ø) |
:arrow_up: |
selection.go | 82.05% <100%> (ø) |
:arrow_up: |
source_manager.go | 91.23% <100%> (+0.88%) |
:arrow_up: |
version_unifier.go | 95.61% <95.61%> (ø) |
|
pkgtree/pkgtree.go | 81.4% <0%> (-3.67%) |
:arrow_down: |
... and 1 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update df000f6...22be9f3. Read the comment docs.
This is almost complete, except one test is still failing in a way that indicates the test harness still isn't quite dealing with the underlying
FAKEREV
s correctly.Fixes #202.