search

sdboyer / gps

your dependencies have arrived
MIT License
270 stars 24 forks source link

A bit of cleaning up the tests #212

Closed jstemmer closed 7 years ago

jstemmer commented 7 years ago

While working on getting Fastwalk (#180) to work correctly (which btw also needs some changes that I'm planning to submit upstream soon), I noticed a bunch of temp dirs were left behind after running all the tests. And while dealing with that I also found some instances of t.Errorf followed by t.FailNow in the tests that could be replaced with a single call to t.Fatalf.

codecov[bot] commented 7 years ago

Codecov Report

Merging #212 into master will increase coverage by 0.27%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #212      +/-   ##
=========================================
+ Coverage   78.03%   78.3%   +0.27%     
=========================================
  Files          28      28              
  Lines        4020    4020              
=========================================
+ Hits         3137    3148      +11     
+ Misses        658     650       -8     
+ Partials      225     222       -3
Impacted Files Coverage Δ
version.go 77.45% <0%> (-0.48%) :arrow_down:
deduce.go 76.49% <0%> (ø) :arrow_up:
pkgtree/pkgtree.go 85.07% <0%> (+3.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6fdcf9...920fde1. Read the comment docs.

sdboyer commented 7 years ago

Thanks! And, weird...looking at git blame, it seems that in some of these cases, I actually moved from t.Fatalf() TO this two-step process call. I've no idea why I did that.