sdboyer / gps

your dependencies have arrived
MIT License
270 stars 24 forks source link

Move LockDiff from dep into gps #213

Closed carolynvs closed 7 years ago

carolynvs commented 7 years ago
codecov[bot] commented 7 years ago

Codecov Report

Merging #213 into master will increase coverage by 0.26%. The diff coverage is 87.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   78.35%   78.62%   +0.26%     
==========================================
  Files          28       29       +1     
  Lines        4020     4169     +149     
==========================================
+ Hits         3150     3278     +128     
- Misses        648      663      +15     
- Partials      222      228       +6
Impacted Files Coverage Δ
version.go 79.06% <84.61%> (+1.13%) :arrow_up:
lockdiff.go 88.23% <88.23%> (ø)
pkgtree/pkgtree.go 81.4% <0%> (-3.67%) :arrow_down:
source_manager.go 90.35% <0%> (ø) :arrow_up:
bridge.go 75.91% <0%> (ø) :arrow_up:
lock.go 95.45% <0%> (+6.81%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9659997...990d452. Read the comment docs.

carolynvs commented 7 years ago

I've renamed it per your suggestion and added tests for nil/empty locks.

sdboyer commented 7 years ago

Great - in we go! Thanks! 🎉

carolynvs commented 7 years ago

In before reorg! 😁

sdboyer commented 7 years ago

🏁 🏁 🏁