Wrong display of number of suppressions in sidebar in GUI

[thijsbenschop]

after applying local suppression. Instead of displaying the number of suppressions, the total number of missing values in thee variables is displayed.

Sidebar:

Information on summary page:

Instead of the right column the left column should be reproduced in the sidebar

[thijsbenschop]

See pull request #258

[bernhard-da]

@thijsbenschop i think this behaviour is intentional and not a bug. because in x@localSuppression$supps, only the additional suppressions of the current run are stored and in the sidebar we want to show the total number of suppressions and not only the new ones I guess.

[thijsbenschop]

@bernhard-da the column header 'suppressions' gives the impression that these values were suppressed by the local suppression algorithm. This isn't necessarily the case, however, as some values may already have been missing in the original dataset. Another option would be to change the column header to 'Total number of missings including suppressions', but doesn't a user want to know the effect of local suppression, rather than the total number of missings? We could add both to the sidebar, but I wonder whether there is sufficient space for that.

Nevertheless, I think the current representation is wrong, as it is labelled 'Suppressions', but in fact the number of suppressions plus the number of missings per variable in the original dataset is displayed.

[bernhard-da]

@thijsbenschop ok, but the column has to be renamed in either way then. Regarding https://github.com/sdcTools/sdcMicro/pull/258, the column name should probably something like ("new suppression introduced by ..."). will you update the pr?

[thijsbenschop]

@bernhard-da , will do that. I also thought it may be helpful to add more information to the table on the summary page, as in the example below:

In order to avoid confusion between suppressions and missings

[thijsbenschop]

Now it looks like this: I also added some text

[bernhard-da]

@thijsbenschop thx, this is indeed better! will merge, once you update the pr.

[thijsbenschop]

@bernhard-da , just updated the pr with the additional info on the summary page and the changed column name ('Additional suppressions by local suppression algorithm')

[bernhard-da]

@thijsbenschop merged, thx!

[thijsbenschop]

Still one more pr #259 with two more improvements:

• column headers in summary page table
• left align values in table in sidebar, as they often aren't visible on smaller screens