search

sdcoffey / techan

Technical Analysis Library for Golang
https://godoc.org/github.com/sdcoffey/techan
MIT License
838 stars 142 forks source link

Represent TimeSeries as an interface #14

Open andviro opened 5 years ago

andviro commented 5 years ago

Hi there!

I've converted TimeSeries from struct to interface, more alike to ta4j. I think it's beneficial because TS can be implemented differently, using Influxdb for example.

codecov[bot] commented 5 years ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (35e5bd2) to head (7b3e45d). Report is 55 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #14 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 28 28 Lines 553 560 +7 ========================================= + Hits 553 560 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

utx0 commented 5 years ago

Any reason @sdcoffey why you havent merged this one? Looks good to me.

sdcoffey commented 5 years ago

Hey guys, sorry for the delay here, for some reason there's an issue with my github settings that causes me to not get notifications about new PRs on this repo.