search

sdcoffey / techan

Technical Analysis Library for Golang
https://godoc.org/github.com/sdcoffey/techan
MIT License
838 stars 142 forks source link

moving average caching bug fix #26

Closed MShoaei closed 3 years ago

MShoaei commented 3 years ago

This commit fixes the issue which is mentioned in #25 and contains the suggested fix.

codecov[bot] commented 3 years ago

Codecov Report

Merging #26 (9120818) into master (e87ec2e) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   99.29%   99.29%   -0.01%     
==========================================
  Files          35       35              
  Lines         566      565       -1     
==========================================
- Hits          562      561       -1     
  Misses          2        2              
  Partials        2        2
Impacted Files Coverage Δ
indicator_moving_average.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e87ec2e...9120818. Read the comment docs.

MShoaei commented 3 years ago

@sdcoffey I know you are busy but I don't know any other maintainer to contact. Could you please check this out?

MShoaei commented 3 years ago

Just tested this with a data set and compared the values with the values calculated by tradingview on the same data and the new implementation creates exactly one extra entry. Going to close this until I figure out the issue