Closed sdd closed 11 months ago
Merging #71 (d4286b1) into master (e1489a7) will increase coverage by
8.57%
. The diff coverage is90.75%
.
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 83.91% 92.48% +8.57%
==========================================
Files 29 44 +15
Lines 3593 5589 +1996
Branches 0 5589 +5589
==========================================
+ Hits 3015 5169 +2154
+ Misses 578 390 -188
- Partials 0 30 +30
Files Changed | Coverage Δ | |
---|---|---|
src/mirror_select_nth_unstable_by.rs | 99.43% <ø> (ø) |
|
src/immutable/float/construction.rs | 42.59% <42.59%> (ø) |
|
src/fixed/distance.rs | 53.57% <53.57%> (+30.31%) |
:arrow_up: |
src/fixed/query/within_unsorted_iter.rs | 79.43% <79.43%> (ø) |
|
src/immutable/float/kdtree.rs | 82.56% <82.56%> (ø) |
|
src/immutable/float/query/approx_nearest_one.rs | 85.71% <85.71%> (ø) |
|
src/best_neighbour.rs | 89.18% <89.18%> (ø) |
|
src/nearest_neighbour.rs | 89.18% <89.18%> (ø) |
|
src/immutable/float/query/best_n_within.rs | 89.31% <89.31%> (ø) |
|
src/float/query/within_unsorted_iter.rs | 93.10% <93.10%> (ø) |
|
... and 31 more |
... and 6 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
NearestNeighbour
,Vec<NearestNeighbour>
, orVec<BestNeighbour>
, for consistency.within
was keeping its results in aBinaryHeap
and calling itsinto_sorted_vec
method to, well, return a sortedVec
. Whilst aBinaryHeap
is great if you are frequently adding and removing items, if your use case is to gradually add all your items, and then sort them all at once, its quicker to just put things in aVec
and then sort theVec
at the end. Benchmarking shows that this change improves performance by anything from 5 to 60% in practice.