search

sde1000 / python-dali

Library for controlling DALI lighting systems
Other
150 stars 73 forks source link

Python 2 compatibility #56

Closed sde1000 closed 4 years ago

sde1000 commented 5 years ago

Does anybody still care about python 2 compatibility for python-dali?

The next lot of code I plan to commit is python 3.5+ only, because it's based on asyncio. Committing it won't break python 2 compatibility for existing code, but I'm just wondering about opportunities for clean-up.

rnixx commented 5 years ago

I'm fine with dropping python 2 support.

dgomes commented 5 years ago

I also support python3.5+

tobiasoort commented 5 years ago

I just migrated my whole stack over to python 3.5 because that's the way the world works now. I'm fine with dropping py2.

mhemeryck commented 4 years ago

Currently in the process of migrating our entire code base at work over the python3 (bit late of the party, I know). Let me know if you could use some help with that, figure it might be a nice opportunity for me to also learn a bit more of this repo.

sde1000 commented 4 years ago

Ok, the consensus appears to be that it's fine to drop support for python <3.5. I'll remove it from the testing and packaging infrastructure soon, and after that there can be a gradual cleanup of python 2.7 compatibility code. I'll leave this issue open until that cleanup is complete.