Unipi axon s605 driver

[mhemeryck]

Fixes #48

Adds driver implementation for Unipi Axon S605. My idea is to use this as part of my home automation setup. I would interface with this driver implementation by adding a mqtt wrapper around it, converting events to commands on my DALI bus.

Implementation taken from https://git.unipi.technology/UniPi/unipi-python-lighting/commit/0975401ba6358d475ef46532ff5271bee46d601a adapted with unit tests. I did check the original code, and it does mention your licence; see https://git.unipi.technology/UniPi/unipi-python-lighting/blob/0975401ba6358d475ef46532ff5271bee46d601a/UnipiDali/unipidali.py#L6

Implementation:

• RemoteArm: interface with underlying hardware using modbus -- extra pymodbus dependency
• UnipiDALIDriver: DALIDriver implementation, for construct / extract
• SyncUnipiDALIDriver: SyncDALIDriver implementation, for send

Tests:

• used unittest for this, in accordance with the rest of the already existing tests (personal preference for pytest though)
• used unittest.mock for patch the actual hardware behavior in some cases
• E2E: tested on the actual device, running python 3.5 in a debian-like environment

Some further notes:

• python3; I did notice some issues in the testing process with python3 compatibility and fixed those for my purposes (both 2 and 3 compatible). Is there some idea to fully port everything to python3 (2 is EOL end of this year)
• dependencies: I've personally become accustomed to using poetry for dependency management, but I can see you'd like to keep it lightweight as it's a library. I did try to look into adding e.g. pymodbus as an "extra" in the setup script but I doubt this would work the unit tests

Note that this is a first proposal, looking forward to hear your remarks!

[dgomes]

Nice contribution!

I've come up with https://github.com/dgomes/dali2mqtt to integrate with Home Assistant through MQTT see if it's of any use to you

[mhemeryck]

The home assistant integration with MQTT is completely what I wanted to do! I'll have a look how it'd work with the unipi driver; will see if I can also create a PR for that. Thx!

[dgomes]

My code is rough and was built for personal use, would really love some PR's :)

(lets move discussion to that repo)

[sde1000]

Thanks for this!

I'm happy to accept the driver code, but I'd like to keep the diff as clean as possible. Could you update this pull request to be just the driver and its tests, and drop the unrelated changes? So really just the files dali/driver/unipy.py, dali/tests/test_unipi.py, and the necessary changes to setup.py (i.e. drop the changes to quote style).

At the same time, please add yourself to the contributors list in README.rst and add a comment in the driver indicating its origin.

I'd be happy to accept a separate pull request for the .flake8 and .gitignore files if you would find that helpful.

I'm working on dali/bus.py at the moment so please just ignore it for now. (The plan there is to integrate it with the async device drivers, and add an example DALI<->MQTT bridge using gmqtt.)

[mhemeryck]

Thanks for this!

I'm happy to accept the driver code, but I'd like to keep the diff as clean as possible. Could you update this pull request to be just the driver and its tests, and drop the unrelated changes? So really just the files dali/driver/unipy.py, dali/tests/test_unipi.py, and the necessary changes to setup.py (i.e. drop the changes to quote style).

OK. This will probably break my py3-based setup for now, since some of the imports (e.g. import Sets) don't work for me.

At the same time, please add yourself to the contributors list in README.rst and add a comment in the driver indicating its origin.

Did this, thx :)

I'd be happy to accept a separate pull request for the .flake8 and .gitignore files if you would find that helpful.

Those are basically just some defaults I'd like to have in the project I work on, since it makes it for my editor to work in (vim). Also, I typically use these as part of linting checks in the CI.

I'm working on dali/bus.py at the moment so please just ignore it for now. (The plan there is to integrate it with the async device drivers, and add an example DALI<->MQTT bridge using gmqtt.)

That's really nice to hear! Looking forward to that.

[sde1000]

Fails on the python 2.7 check, but I'm not going to worry about that since I'm removing it shortly.

[mhemeryck]

Fails on the python 2.7 check, but I'm not going to worry about that since I'm removing it shortly.

Just noticed it and fixed the import issue (just in time apparently, since you just merged it in :)).

Thx anyways, will certainly keep an eye on this repo and will look into how I can contribute in the future.

[mhemeryck]

btw, will this get its own tag / release / pypi artifact?

[sde1000]

Next time a release happens, which will probably be when I have the asyncio stuff in a suitable state. Not too long, hopefully!