search

sde1000 / python-dali

Library for controlling DALI lighting systems
Other
150 stars 73 forks source link

hasseb firmware and drivers without graphical user interface #67

Closed hasseb closed 4 years ago

hasseb commented 4 years ago

I would like to merge hasseb firmware and drivers. All comments from the earlier pull request should be fixed. The gui folder was removed.

dgomes commented 4 years ago

What's in the .dll file ?

sde1000 commented 4 years ago

I assume it's something to do with accessing HID devices under Windows. It needs to be a dependency, not something included in the repo.

sde1000 commented 4 years ago

I'm going to put my test kit back together tomorrow and go through this. Hopefully I can also update the async driver to work well with it.

hasseb commented 4 years ago

There were also some discussion about the firmware folder in the earlier pull request. I think it is up to Stephen to decide will it be included or not.

hasseb commented 4 years ago

I think it is now better to remove the firmware folder and hasseb_test.py and the bus related code from the driver. Then we can finish this pull request. Any issues found from the firmware can be commented in my master here https://github.com/hasseb/python-dali. All removed files are still available at my master above. Only the new driver file hasseb.py and the new commands in command.py will remain.

dgomes commented 4 years ago

@hasseb what everyone is advising is that a new GitHub repository is created to handle all this stuff: firmware, GUI, documentation.

Call it "hasseb-dali"

If you need help feel free to reach-me

hasseb commented 4 years ago

I would like to make the firmware source code open. The problem is that it is based on an example code from NXP. It is highly modified, but there is still something from NXP.

dgomes commented 4 years ago

I would like to make the firmware source code open. The problem is that it is based on an example code from NXP. It is highly modified, but there is still something from NXP.

You can release a patch to the NXP code instead of releasing the modified version. This is something I've seen in other projects, eg. https://github.com/Koenkk/Z-Stack-firmware/tree/master/coordinator/Z-Stack_Home_1.2

sde1000 commented 4 years ago

Ok. Nearly there. Two things to do before I can merge this:

  1. The additional commands should be in a separate pull request. Please add a note in their docstrings giving the version of the standard in which they were introduced.
  2. Please rebase+squash on current master. (You'll need to force-push after doing this.)

I still have comments to make on the new firmware, but I'll wait until it has its own issue tracker; this isn't the place.

Thank you!