sde1000 / python-dali

Library for controlling DALI lighting systems
Other
150 stars 71 forks source link

Support for DALI memory banks — continued #92

Closed sde1000 closed 2 years ago

sde1000 commented 2 years ago

This pull request incorporates and builds upon all the commits from #76 by @ferdinandkeil.

For a full list of changes see the commits, but briefly:

Code that works with @ferdinandkeil's pull request #76 should continue to work with this, although you may see slightly different types being returned for some memory values (eg. Decimal rather than float for scaled values) and there's the possibility of a dali.memory.location.FlagValue being returned for memory locations that have invalid contents or which have values TMASK or MASK.

I don't think this is finished yet, but I'm ready for comments from people testing the code. Outstanding issues include:

ferdinandkeil commented 2 years ago

Very cool :star_struck: Soooo many improvements over my code.

I'll test it once my current experiment is finished.

About the ASCII characters: you could either ignore all bytes above 0x7F or render them as a space character.

sde1000 commented 2 years ago

With the "latch while reading whole memory bank" feature and the tidy-up of exceptions, I think this is now ready for merging. Testing and comments would be appreciated!