sdebaun / sparks-cyclejs

45 stars 4 forks source link

directory structure to match routing #25

Closed sdebaun closed 8 years ago

sdebaun commented 8 years ago

Proposed change of directory structure:

/src
  /app
    index.js (currently App.js)
    /Admin (as is)
    /Dash (Dash.js when it expands to have multiple subpages)
    /Confirm.js (single page route at /confirm)
    /Landing.js (same)
  /components (everything else remains for now)

the notion is that everything in /app should be unique to wherever it is in the routing tree. maybe /routes is a better name?

still thinking on how to organize everything else... i see three kinds of things so far:

@TylorS thoughts?

TylorS commented 8 years ago

I'm right there 100% on restructuring a bit to match how we are routing, I don't see why we should hesitate to do that. It will make it easier to navigate around. I think I like /routes better just because that explains the hierarchy a bit better, as everything is the App.

domain-specific components

I think the best bet for now is to keep them domain-specific, and refactor as time goes on and we know how to properly abstract them. e.g. We have more information on how we're going to use them, at which point they will probably be made more of a generic component with optional parameters sort of like snabbdom-material.

generic components

Just keeping those inside of the components folder makes plenty of sense

render functions

I think your /helpers/dom.js could eventually be created into a /helpers/dom/... folder to accommodate more generic renderFoo() functions, or perhaps a /view folder could be created specifically for those?