search

sdec-brasil / invoice-explorer

API + Interface Pública para Resgate de Informações do SDEC
MIT License
1 stars 0 forks source link

Track Features (Stats) that we need from the API #9

Open tloriato opened 5 years ago

tloriato commented 5 years ago

We'll be aligning the front-end design with the API, so here this issue will be used to track all stats that we are going to need and where are we serving them.

dbeyda commented 5 years ago

Issues

sdec-brasil/dashboard-publico#5 (General Stats from a Single City) sdec-brasil/dashboard-publico#4 (Expected revenue in the end of the month for a Single City) sdec-brasil/dashboard-publico#3 (Total Value in Late Invoices from a Single City)

could all use the same endpoint, that would return general stats for a city.

dbeyda commented 5 years ago

To issues sdec-brasil/dashboard-publico#8, sdec-brasil/dashboard-publico#7, sdec-brasil/dashboard-publico#6, sdec-brasil/dashboard-publico#4, sdec-brasil/dashboard-publico#2, I believe each of them should have its separate endpoint.

tloriato commented 5 years ago

Maybe I'm wrong but I don't exactly agree right now with your comments.

sdec-brasil/dashboard-publico#2 deals with revenue (R$) as well as sdec-brasil/dashboard-publico#4 and sdec-brasil/dashboard-publico#3, so I don't think we should treat them separately?

Maybe we can serve them all in the /city/{id} endpoint but some only in /city/{id}/{feature}.

Either way we can decide this later

dbeyda commented 5 years ago

After reviewing the issues, I think I agree with you. Each issue in a separate endpoint, right?