Closed sverrejoh closed 9 years ago
Thanks @sverrejoh, I just created #12 for evaluating your recommendation (so I don't forget now that I merged/closed this pull request.
+1. Exporting a separate object would really be useful in order to not pollute the global namespace. You could use https://github.com/umdjs/umd in order to export the correct format for all environments.
I added a package.json so the module can be installed as an NPM package with Browserify.
With this you can install the package with npm:
And then use the page with require from your Browserify project:
Build into one bundle containing everything with Browserify:
I didn't change the code at all, this is just metadata.
I think it would be nice if the package had its own namespace, which exported
addResizeListener
andremoveResizeListener
, so you could use the code like this (instead of putting it on window):But this requires some change in your code, and build step, so I didn't want to start on it.
Using Browserify you could have the canonical version as a Browserify/CommonJS module, and then just from that generate a package that works standalone, or with AMD/Bower.
https://github.com/substack/browserify-handbook#standalone
As I said, a little bit of changes, but I'd love to help if you're interested :).