search

sdefresne / gerrit-monitor

Source for Gerrit Monitor Chrome extension
Apache License 2.0
21 stars 16 forks source link

CLs without me in attention set are listed as "Needing Attention" #42

Open studgeek opened 2 years ago

studgeek commented 2 years ago

I have CLs without me in the attention set being listed as "Needing Attention". They are newly uploaded CLs without any reviewers. I do have "Only use Attention Set to judge required attention" set.

Unfortunately the example commits I have are all in a Google internal repo. I email you them directly. Thx!

justinlulejian commented 2 years ago

I'm seeing this issue in the public chromium Gerrit and can reproduce it. I'm the owner of the CL, but when I'm not listed in the attention set they still show as needing my attention in the extension. At the current moment I'm actually in the attention set, but multiple hours went by earlier today where this issue was true.

justinlulejian commented 2 years ago

Here's a screenshot showing where I'm not in the attention set, but the extension still lists the CL as needing my attention. Screen Shot 2022-09-28 at 2 37 55 PM

sdefresne commented 2 years ago

The extension only fetches the information from gerrit every five minutes and then caches the result. Is it possible that the attention set changed less than five minutes ago?

justinlulejian commented 2 years ago

The README says:

On click, it also polls the server to display the popup (and refresh the badge).

So does that poll not invalidate the cache of the result?

Nonetheless, for the example in the screenshot, it's been over two hours of not being in the attention set and it still lists the CL as requiring attention.