sdefresne / gerrit-monitor

Source for Gerrit Monitor Chrome extension
Apache License 2.0
21 stars 16 forks source link

Only use attention set even for Approved commits #43

Open studgeek opened 2 years ago

studgeek commented 2 years ago

Currently if "Only use Attention Set to judge required attention" is enabled, GerritMonitor still sends notifications for Approved commits.

I would expect those to be managed by attention set also. Gerrit will mark them as needing attention when they are approved. Using attention set allows the user to turn off attention in Gerrit if they want to wait to commit (for example if they are waiting on multiple approvals or something else to happen).