Add support for 1:1 chat

[fmvilas]

Do you plan to support 1:1 chat?

[rockneverdies55]

:+1:

here is another small bounty added... :-)

[dfyx]

:+1:

[miscs]

+1 dreaming of 0.5 :)

[corn13read]

+4

[fisle]

+1, this is the dealbreaker which completes the package and makes let's chat super useful in pretty much every scenario, IMO.

[brad-x]

Would love to see 1:1 chat in the web UI. Private rooms exist and can be passwordlessly created - even something as simple as automatically creating such a room and autojoining the messaged user to it would do the trick.

Mind you, I'm assuming this should "work like an XMPP server" in which case that's likely not the way to go.

[rghv]

:+1:

[mabahj]

+1 would love to be able to send a small private message to one user in the current room. "/msg user hello"

[dexdexdex]

+1

[USA-RedDragon]

Is this still open and valid?

[funkaoshi]

Yes. It's still on the roadmap.

[warent]

I'm refactoring basically all of the old code. The vagrantfile is completely outdated, node is still behind the old io.js, and npm is extremely old as well. I'm also probably going to get rid of grunt in favor of gulp, and bower is completely obsolete now with npm as well.

You can watch my changes here https://github.com/warent/lets-chat/tree/refactor

[warent]

By the way, I don't personally see the purpose of docker or heroku since we're using vagrant. Can anyone make an argument to keep all three?

[geoffwhittington]

I wrote the original vagrantfile and I'm overwhelming in favour of an update

[warent]

Splendid, then I'm settling on vagrant as opposed to the other two simply because I'm more familiar with vagrant than docker, and I personally always found heroku + vagrant to be redundant. I'm going to see about removing bower now and swapping out grunt for gulp

[warent]

Eventually need to get rid of jquery, backbone, handlebars, and bootstrap. All of that stuff is now obsoleted by AngularJS

[sibartlett]

Hi Wyatt /@warent,

Could you open a separate issue for discussions that are unrelated to 1:1 chat? I don't want to flood the inboxes of the 50 other participants on this ticket.

Regarding Docker and Heroku: We'll still want to keep them. There's a large number of people using Docker, and Heroku is really useful for setting up a quick demo installation.

Regarding AngularJS: We're looking to switch to React and Redux.

Again, let's discuss all of this in a separate GitHub issue.

[MachineCity]

+1 Happy 2016!

[spantula]

+1, we need this asap

[funkaoshi]

Great news! Looks like Team Stitch has added 1-1 chat support ... someone just needs to bug them to push their changes back to us. Ha!

No wait, they've sadly moved off Let's Chat to their own backend.

[JemiloII]

So what is the status of this? I just learned of this project from some bounty hunter website. Looks interesting but at the same time it, it looks complete?

https://www.bountysource.com/issues/8741867-add-support-for-1-1-chat, but then I see Private 1-to-1 chat #319 as merged?

[digination]

This is not done. 1-1 chat works but only over XMPP. 1-1 direct messages should also work from the Web UI, but it's not the case..yet.

[asifmallik]

Can I start working on this now?

[MachineCity]

Yes.

You have my permission.

Sorry about the long wait. ;-)

On Aug 18, 2017 2:23 AM, "Asif Mallik" notifications@github.com wrote:

Can I start working on this now?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sdelements/lets-chat/issues/282#issuecomment-323270199, or mute the thread https://github.com/notifications/unsubscribe-auth/AIIXEp5DLtXe7O9BMScTkQZ3174Jn6inks5sZS3jgaJpZM4DjPVX .

[armand1m]

I'm starting this one =) seems stopped for too much time and appears fairly easy. It has any specifications on how this should work? If so, please let me know before I take design decisions myself 😄

I'll start some work today, and hopefully get a new PR at this week.

[mmeinert]

@armand1m :+1: Very curious/impatient to see this feature in let's chat. Wish you success.

[armand1m]

Ok, I've started working on this, I've saw that there are only ways to create rooms and send messages into those rooms. The messages send a message:create from the client and the client updates when it receives a message:new event from server.

The client sends this payload when emitting message:create:

{
  "room": "5a48305380fddc000f393e4c",
  "text": "a message"
}

The server sends this payload when emitting message:new:

{
  "id": "5a484d1a80fddc000f393e5e",
  "text": "a message",
  "posted": "2017-12-31T02:36:10.295Z",
  "owner": {
    "id": "5a48304380fddc000f393e4b",
    "firstName": "armando",
    "lastName": "magalhaes",
    "username": "armand1m",
    "displayName": "armand1m",
    "avatar": "41caf1579a4eb2d6b43efdf2db961681"
  },
  "room": {
    "id": "5a48305380fddc000f393e4c",
    "slug": "teste",
    "name": "teste321",
    "description": "321teste",
    "lastActive": "2017-12-31T02:36:10.295Z",
    "created": "2017-12-31T00:33:23.418Z",
    "owner": "5a48304380fddc000f393e4b",
    "private": false,
    "hasPassword": false,
    "participants": []
  }
}

Having this said, I need to be sure about how we're going to design this to handle a 1:1 chat.

My questions are:

• Do the team or the project has some problem in using the same interface from message:new, but using an user id at the room key instead of the room id? it may keep some compatibility and make this implementation easier.

• Or the team would prefer a different kind of event to be emitted from server when started a 1:1 chat session?

• About UI, I saw that there is a collapsible sidebar in the right that lists the users in a room so we can add a mention to them in our messages. Would be nice to have a right button in these list items so a user can DM another user in the same room? Or it would be better if we create a section in the left sidebar for only showing registered users/online users and starting chats? The user needs to know where to find the user so he can contact him, hehe.

Also saw that you guys use Vagrant to build the development environment, is there any problems if I create some extra files in the docker folder for enabling using docker as a development environment as well? Please let me know.

[armand1m]

@digination said:

This is not done. 1-1 chat works but only over XMPP. 1-1 direct messages should also work from the Web UI, but it's not the case..yet.

Is this true? The XMPP impl is already capable of handling 1-1 direct messages? Is this the file defining the event responsible for that? https://github.com/sdelements/lets-chat/blob/master/app/xmpp/events/usermessage-created.js

[armand1m]

Hum, ok, I was waiting for some answers for this, but since there are none in almost a week, will do it my way 😄

I tried to send private messages through XMPP using Adium but got no success, although I could successfully send messages in rooms.

I'll implement this feature in browser environments for now.

[alromh87]

Is this still something needed or should it be closed in favour of the XMP implementation of 1:1 chat?

[MachineCity]

Yes.

On Sat, Sep 12, 2020, 11:01 AM Alejandro Romero notifications@github.com wrote:

Is this still something needed or should it be closed in favor of the XMP implementation of 1:1 chat?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/sdelements/lets-chat/issues/282#issuecomment-691503031, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBBOEXSKHAWASH2DYET5G3SFOENJANCNFSM4A4M6VLQ .