search

sdelements / lets-chat

Self-hosted chat app for small teams
http://sdelements.github.io/lets-chat
MIT License
9.77k stars 1.58k forks source link

pasport.socketio current minor version requires a version change of passport package #603

Closed mootpt closed 9 years ago

mootpt commented 9 years ago

https://github.com/sdelements/lets-chat/blob/master/package.json#L89-L93

https://github.com/jfromaniello/passport.socketio pushed out 3.6.1, unfortunately the passport version in letschat uses "passport": "^0.2.2" and "passport.socketio": "^3.5.1".

socketio returns a dependency issue as it expects passport version 0.3.0 and "^0.2.2" does not meet this requirement:

npm WARN peerDependencies The peer dependency passport@~0.3.0 included from passport.socketio will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.

Hope this makes sense. Seems you will need to modify the passport version: https://github.com/sdelements/lets-chat/pull/602

This seems to have resolved the issue for me.

mootpt commented 9 years ago

actually.. may have opened this issue too soon. closing for now.