Weird spacing for icons on buttons on the 'Configure Game Settings' form

bluesatin commented 3 years ago

Issue

On buttons that have icons within the 'Configure Game Settings' form, there are rather large and weird looking gaps between the icon and the actual button text.

Screenshot

Cause

This seems to be caused by the label selector + style starting on line:127 in the CSS file, that appears to be designed for the labels above the buttons but is also applying to the label within buttons; causing the rather large gap between the icon and text on buttons.

Discussion

Adding in an unset to the margins on labels within buttons seems to be the easiest way to fix the gap without touching anything else, like trying to make the label selector that adds the margin more specific.

Something like:

#client-settings section.content .submenu button label {
    margin: unset;
}

Thanks for the module, makes dealing with module-settings so much easier! :)

sdenec commented 3 years ago

Never noticed this. Well, it's partly because of the strange markup with labels inside buttons. But yeah, your fix will work. It's nothing mod breaking though and doesn't require an immediate update. Anyway, I'll keep it in mind!

sdenec commented 3 years ago

Finally got around to remove the spacing^^

sdenec / tidy-ui_game-settings