search

sdenec / tidy5e-sheet

An alternative Character Sheet for Foundry VTT dnd5e aimed at creating a cleaner UI.
86 stars 98 forks source link

[BUG] Possibly bug - Order of items in inventory determines order of item categories. #810

Open HydrallUrakan opened 7 months ago

HydrallUrakan commented 7 months ago

Module Version: v0.2.19

Describe the bug I noticed when updating to this version of Tidy5e that one of my characters had bonus actions above actions in their sheet - and only one of them. Eventually, I determined that the cause was that their inventory had a weapon activated as a bonus action as its first item; changing the activation, or the order, changed what would be displayed.

To Reproduce Steps to reproduce the behavior:

  1. Create or open a character sheet.
  2. Make the first item in the character's inventory use a bonus action to activate.
  3. Go to the "actions" tab.
  4. See the misordered items.

Furthermore, if you were to have the order be otherwise, e.g. bonus action - reaction - action - the categories would be in that order as well.

Expected behavior Presumably the categories would have a consistent order - perhaps one that could be customized? But that might fall under enhancement instead.

Screenshots image image image image

Browser:

Foundry Version: v11.315

Game System: v2.4.1

Additional context Add any other context (like other modules installed) about the problem here.

kgar commented 7 months ago

Thanks for reporting! If possible, can you forward this to the new Tidy repo? https://github.com/kgar/foundry-vtt-tidy-5e-sheets

I believe we should start with a set order representing the most logical ordering, and we can make the reordering a feature enhancement request. Reordering is something I am very interested in providing to Tidy.

kgar commented 6 months ago

I am finally able to start working on this. For now, I will be setting a deterministic ordering of action list sections. Later, I'll work a feature to allow for custom ordering of sections for a given user per actor type, per tab, but that'll be a bigger feature addition to come later. If you'd like to make any suggestions or recommendations on the default order of the action sections, feel free to comment here: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/issues/404

kgar commented 5 months ago

I finished this over on the new repo linked above a little while back.