sdenec / tidy5e-sheet

An alternative Character Sheet for Foundry VTT dnd5e aimed at creating a cleaner UI.
86 stars 98 forks source link

TidySheet with new SRD 3.0.1 makes monster stat blocks not show #812

Open Skywolf-Software opened 7 months ago

Skywolf-Software commented 7 months ago

Module Version: v0.10.0

Before open any issue Sorry, away from computer, unable to try this, but problem is easy to reproduce as described below 1) Enable the module setting "Enable debugging" 2) Click F12 go to the console tab 3) make the test you want and replicate the error 4) Go to the tab console open on point 2) and just right click and click 'Save as' and 'Save' or send a screenshot of the exception on the console. 5) Attach the text file on the github issue with all the logs related tot he module, or send a screenshot of the messages on the console.

Describe the bug With new 5E SRD v3.0.1, and TidySheet enabled, monster stat blocks do not show (characters are ok and can show Tidy, new 5E sheet, or legacy 5e sheet)

To Reproduce Steps to reproduce the behavior:

  1. install 5e SRD 3.0.1
  2. Install TidySheet - do not activate yet
  3. Disable all modules but 5E SRD
  4. Drag a monster from SRD to your items area
  5. Double click monster and see default NPC/Monster block
  6. Enable TidySheet module
  7. Repeat 5 (or 4 and 5) - but now stat does not open

Expected behavior Monster / NPC sheet, or Tidy version of it, opens when double clicking a monster

Screenshots NA

Browser: Chrome

Foundry Version: 11.? - sorry away from computer, it is perhaps 11.53 or something like that - the latest as of Feb 3rd 2024

Game System: DnD 5e

Additional context

kgar commented 7 months ago

Thanks for reporting.

Is "5e SRD 3.0.1" a module? Or is this referring to the dnd5e 3.0.1 system version?

If it's referring to the system version 3.0.1, Tidy5e Sheet 0.10.1 has a hard version cap set to 2.4.0-2.4.9, and enabling it should not be an option in dnd5e 3.x.

Skywolf-Software commented 6 months ago

Hi Kevin.

Yes I'm referring to the 5e rules srd 3.0.1

I can't speak to the version cap. But I'll try to do a fresh install of Tiny and see if my ability to turn it on (and break things doing it) goes away.

The world, in case it matters, was done with srd 2 something and then upgraded to 3, then 3.0.1.

Maybe something in upgrade messed up the version controller?

I'll let you know what a reinstall of tiny does.

Are there any plans to make tiny compatible with 5e srd 3?

Jens

On Fri, Feb 9, 2024, 11:47 AM Kevin Lee Garner @.***> wrote:

Thanks for reporting.

Is "5e SRD 3.0.1" a module? Or is this referring to the dnd5e 3.0.1 system version https://foundryvtt.com/packages/dnd5e?

If it's referring to the system version 3.0.1, Tidy5e Sheet 0.10.1 has a hard version cap set to 2.4.0-2.4.9, and enabling it should not be an option in dnd5e 3.x.

— Reply to this email directly, view it on GitHub https://github.com/sdenec/tidy5e-sheet/issues/812#issuecomment-1936256374, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFK32JWMPOGTV6QB6QTSOJTYSZHLVAVCNFSM6AAAAABC5GHSO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZWGI2TMMZXGQ . You are receiving this because you authored the thread.Message ID: @.***>

kgar commented 6 months ago

Tidy 5e Sheets version 1.0.0 has released for dnd5e 2.4.1 with the version cap. The new version of Tidy is a complete rewrite. The new repository is here: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/

I have begun work on dnd5e 3.x compatibility. I do not have an estimate for when it will be ready, but it is in progress now. I hope it is worth the wait.

Skywolf-Software commented 6 months ago

I'm glad to hear that srd 3 will be supported. :-) I'm sure it will be worth the wait. We (DM me + 7 players) all love tidy. Compared to it regular, and the new 5e sheet take so much space on your screen you can barely see the map. And I got a big screen, but in a fight w 3+ monsters I'm out of room. So much space wasted in pretty header of new sheet :(

On that note: 1 can I support the effort? QA? $? 2 please consider developing it to work with pop out so sheet can be pulled to a second screen

On Tue, Feb 13, 2024, 1:00 AM Kevin Lee Garner @.***> wrote:

Tidy 5e Sheets version 1.0.0 has released for dnd5e 2.4.1 with the version cap. The new version of Tidy is a complete rewrite. The new repository is here: github.com/kgar/foundry-vtt-tidy-5e-sheets/

I have begun work on dnd5e 3.x compatibility. I do not have an estimate for when it will be ready, but it is in progress now. I hope it is worth the wait.

— Reply to this email directly, view it on GitHub https://github.com/sdenec/tidy5e-sheet/issues/812#issuecomment-1940475330, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFK32JR4GRCBDXWFXE5N3CLYTL6QLAVCNFSM6AAAAABC5GHSO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBQGQ3TKMZTGA . You are receiving this because you authored the thread.Message ID: @.***>

kgar commented 6 months ago

I really like Tidy sheets, too. I originally did a rewrite to allow my table to continue using the sheets.

If you'd like to support the new Tidy 5e Sheets, I've got support links here: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/?tab=readme-ov-file#how-to-support

Regarding QA, when you are able to use the new sheets in dnd5e 3.x, we are accepting github issues like this on the new repository. Tidy has a very short release cycle (every few days), and I make small, incremental improvements and correct any bugs, so fixes come out quickly if they are found and reported.

Skywolf-Software commented 6 months ago

Cool

On Tue, Feb 13, 2024 at 10:03 AM Kevin Lee Garner @.***> wrote:

I really like Tidy sheets, too. I originally did a rewrite to allow my table to continue using the sheets.

If you'd like to support the new Tidy 5e Sheets, I've got support links here: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/?tab=readme-ov-file#how-to-support

Regarding QA, when you are able to use the new sheets in dnd5e 3.x, we are accepting github issues like this on the new repository. Tidy has a very short release cycle (every few days), and I make small, incremental improvements and correct any bugs, so fixes come out quickly if they are found and reported.

— Reply to this email directly, view it on GitHub https://github.com/sdenec/tidy5e-sheet/issues/812#issuecomment-1941712657, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFK32JSGGY5536NIUYTTTWLYTN6FXAVCNFSM6AAAAABC5GHSO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRG4YTENRVG4 . You are receiving this because you authored the thread.Message ID: @.***>

Skywolf-Software commented 6 months ago

FYI I updated to 5E SDK 3.0.2 and made sure I have latest version of Tiny The version control when I try to turn Tiny in in world with 3.0.2 now correctly tells me the version not supported.

On Tue, Feb 13, 2024 at 7:51 PM Skywolf @.***> wrote:

Cool

On Tue, Feb 13, 2024 at 10:03 AM Kevin Lee Garner < @.***> wrote:

I really like Tidy sheets, too. I originally did a rewrite to allow my table to continue using the sheets.

If you'd like to support the new Tidy 5e Sheets, I've got support links here: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/?tab=readme-ov-file#how-to-support

Regarding QA, when you are able to use the new sheets in dnd5e 3.x, we are accepting github issues like this on the new repository. Tidy has a very short release cycle (every few days), and I make small, incremental improvements and correct any bugs, so fixes come out quickly if they are found and reported.

— Reply to this email directly, view it on GitHub https://github.com/sdenec/tidy5e-sheet/issues/812#issuecomment-1941712657, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFK32JSGGY5536NIUYTTTWLYTN6FXAVCNFSM6AAAAABC5GHSO6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRG4YTENRVG4 . You are receiving this because you authored the thread.Message ID: @.***>

kgar commented 6 months ago

This is intentional. I am still working on 3.0.x compatibility. I will have a URL-only beta release available when I've worked out all of the changes and breakages caused by dnd5e 3. After a few days in beta, I hope to release an official version for everyone.

kgar commented 6 months ago

Hello, friend. I am reposting from discord:

Tidy 5e Sheets Version 2.0.0-beta.1 Released

Github release: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/releases/tag/v2.0.0-beta.1 module.json: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/releases/download/v2.0.0-beta.1/module.json

:rotating_light: For dnd5e 3.0.x :rotating_light:

The Tidy Open Beta for dnd5e 3.x is Here :dragon:

The URL-only open beta for Tidy 5e Sheets support in dnd5e 3x has begun. There are a number of things to polish, and there are whole features to implement from scratch (such as containers and hiding unidentified item content). There are migrations to make (dnd5e 3.x now has Age, Eyes, Skin, etc.; so Tidy will be retiring its own version of those fields).

I will be aggregating a full list of features and planned updates in this milestone as the days go by: https://github.com/kgar/foundry-vtt-tidy-5e-sheets/milestone/3

The goal of this beta is for dnd5e 3.x users, or those who have been ready to go to 3.x, to be able to try out the sheets in the latest dnd5e system version. I will be addressing any issues that arise and can/will release additional beta pre-releases. In the background, while I wait, I will be working down those milestone feature rollouts.

As always if you are jumping to a new version of dnd5e, don't forget to backup your world.

Feel free to file issues if something isn't quite right when compared to the legacy sheets. I request you mention dnd5e 3.0.x in the title, such as bug: (dnd5e 3.0.x) Vehicles Fail to Polymorph into Liches.

Cheers, everyone.

Forge Users: This Release Might Show Up in Your Options

If you are using Forge, you might see the v2.0.0-beta.1 version appear in your options. I have not published an official package for v2 Tidy to Foundry, so this may come from some other factor. Be advised that Tidy v2.0.0-beta.1 is for dnd5e 3. If you accidentally update Tidy, you can safely downgrade back to v1.x Tidy.