search

sderacy / gooncard

The Goon Squad's Goon Card Project for CSC 355 ('22)
http://gooncard.hpc.tcnj.edu:3000/
MIT License
6 stars 2 forks source link

Not found page #101

Closed lelekaz closed 2 years ago

lelekaz commented 2 years ago

Makes a not found 404 page for nonexistent or expired business cards.

sderacy commented 2 years ago

Oh wait, is the difference between #100 and this PR that the not found page is in here? A lot of the code looks similar

sderacy commented 2 years ago

@lelekaz since the changes you make in #100 are encompassed in this pull request, wouldn't it make more sense to close #100 and to merge this one?

I wanna hear your thoughts since you made them but I don't see what #100 does different than #101 other than not having the 404 page which is going to be included.

lelekaz commented 2 years ago

@lelekaz since the changes you make in #100 are encompassed in this pull request, wouldn't it make more sense to close #100 and to merge this one?

I wanna hear your thoughts since you made them but I don't see what #100 does different than #101 other than not having the 404 page which is going to be included.

Sounds good! I'm down with that