search

sderacy / gooncard

The Goon Squad's Goon Card Project for CSC 355 ('22)
http://gooncard.hpc.tcnj.edu:3000/
MIT License
6 stars 2 forks source link

Restructure Settings Page #117

Closed thadakn1 closed 2 years ago

thadakn1 commented 2 years ago
sderacy commented 2 years ago

I looked into implementing a better settings page, and while I have found some good examples that we can base our settings page off of, I don't think implementing them would be a good use of our time. If we intended to have this as a desktop app, having a more intuitive interface for computer users would make sense, but most good designs will default back to the format we currently have on a mobile screen.

Keeping this in mind, I vote to close this issue as I don't think this a problem that needs fixing or a problem that is worth our time.

What do you think? @thadakn1 @matyis1 @thadakn1 @paytonshaltis

thadakn1 commented 2 years ago

I think you are completely right, I’ve been kinda wracking my brain trying to think about how we could possibly restructure it so it looks better for the mobile view but it doesn’t seem to be worth it. It works and it’s simple and at the end of the day I think that’s all that matters. I really did try to think about how we can make it more appealing to the eye though but I don’t think it’s a pressing concern. Anything I can think of really just involved background changes and the formatting of the fields but they look fine on the mobile view.

That being said, I think you should keep the issue open because I’m working on the “button that allows users to delete their goon card account” and the modal. I did some work today but need more time. So please don’t close it for that reason. I will try to work on it earlier this week hopefully.

On Nov 12, 2022, at 11:45 PM, Sterly Deracy @.***> wrote:

 I looked into implementing a better settings page, and while I have found some good examples that we can base our settings page off of, I don't think implementing them would be a good use of our time. If we intended to have this as a desktop app, having a more intuitive interface for computer users would make sense, but most good designs will default back to the format we currently have on a mobile screen.

Keeping this in mind, I vote to close this issue as I don't think this a problem that needs fixing or a problem that is worth our time.

What do you think? @thadakn1 @matyis1 @thadakn1 @paytonshaltis

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.