search

sderacy / gooncard

The Goon Squad's Goon Card Project for CSC 355 ('22)
http://gooncard.hpc.tcnj.edu:3000/
MIT License
6 stars 2 forks source link

Settings changes should show up right away. #133

Closed paytonshaltis closed 2 years ago

paytonshaltis commented 2 years ago

In the settings page, when a user changes a setting, the page should change immediately in order to show the user the effect of their setting changes.

sderacy commented 2 years ago

Does it not currently do this?

paytonshaltis commented 2 years ago

Does it not currently do this?

I mean before they click submit. That way they can see a preview of what the site will look like for them before actually committing to the settings changes.

I'll add the change to your PR so we can keep it all together.

sderacy commented 2 years ago

Go for it, let me know what you think of the bug regarding the default styling we talked about in class.

That's the only real issue I see with my implementation so if we can find a solid fix to the refresh bug, it's probably ready to go.