search

sderacy / gooncard

The Goon Squad's Goon Card Project for CSC 355 ('22)
http://gooncard.hpc.tcnj.edu:3000/
MIT License
6 stars 2 forks source link

Adds dynamic displaycard generation. #151

Closed paytonshaltis closed 1 year ago

paytonshaltis commented 2 years ago

DON'T MERGE UNTIL AFTER CODING MILESTONE 2!

Closes #113. Introduces a small bug that will be fixed after #149 is merged.

Dynamic card content can now be seen for a specific Goon Card! Scanning the QR Code and navigating to the generated dynamic card now shows the first and last name of the owner, as well as the accounts that they selected to be shared for that card.

NOTE: This PR introduces a small bug. If you try deleting an account that is associated with some generated Goon Card, the display card page may show 'undefined undefined' for the user's name. This bug is fixed in #149 by implementing the proper cascade code, meaning that deleting any user_account entry will delete all corresponding card_entry entries, so be mindful of this while testing.

thadakn1 commented 2 years ago

just ran it, incredible work @paytonshaltis !! worked perfectly on my end! 👏🏼