search

sdether / josh.js

Toolkit for building a bash-like shell in the browser, including full readline support
http://sdether.github.com/josh.js/
Apache License 2.0
390 stars 76 forks source link

Remove jQuery Dependency #29

Open regnerus opened 9 years ago

regnerus commented 9 years ago

Is it a possibility to remove jQuery in shell.js and pathhandler.js? It seems a bit overkill to me to add such a heavy dependency.

sdether commented 9 years ago

Pathhandler.js doesn't actually use it, so removing it there is no problem. Shell.js on the other hand is the optional UI layer and requires some cross-browser compatible DOM manipulation. Since it already makes DOM assumptions that are likely at odds with a lot of frameworks, I'd rather re-invent that wheel and let people opt-in to use shell.js with the jQuery or adapt their own shell based no their favorite DOM abstraction.

I'm not opposed to a pull request that rips it out as long as the DOM code does cover the usual suspects of browsers.