sdether / josh.js

Toolkit for building a bash-like shell in the browser, including full readline support
http://sdether.github.com/josh.js/
Apache License 2.0
390 stars 76 forks source link

Remove Activation and deactivation keyhandling from readline #7

Closed sdether closed 11 years ago

sdether commented 11 years ago

This should be controlled from the outside, otherwise handling loss of focus vs. hiding becomes ugly. And instead of Ctrl-C, Ctrl-D and Esc deactivating readline, it should instead be possible to subscribe to key-events not handled by readline, so that they can be externally wired up as deactivation triggers and still be marked as handled without users of readline having to resort to external keyhandling. That also means that commands could be wired up to readline ctrl sequences.

sdether commented 11 years ago

https://github.com/sdether/josh.js/pull/9