Closed sdetweil closed 3 years ago
You gotta love a guy that writes his own issues.
Brilliant piece of work, bro.
so,when there are multiple 'modules' of the same name in config.js, there is a 'list', that will be in order, top down on the first discovery, and maintained from then on. how should they be labeled? see below (each not expanded to not take up too much form room at the start) once u expand it, then if all the lists of modules use the same 'list entry'.. it might be hard to figure out where u are.... but it seems dumb to put the module name in the list entries too
will need to use that same label in the positioning section under the module header...
with module name
Would it be possible to have the user decide? E.g. have them give the module an own id?
{
module: MyCovid19,
id: 'Covid19-Page1',
position: 'top_left',
config: {
}
},
{
module: MyCovid19,
id: 'Covid19-Page2',
position: 'top_left',
config: {
}
},
A fallback in case of no given id would then be your 2nd suggestion 'MyCovid19 list entry 1'
@lavolp3 I had considered that, but if its just decorative, then that wouldn't be a problem. ( I would keep the numerical order under the covers)
I have just pushed the 1st pass at multi-module from a user perspective..
can't submit the form,
git pull git fetch git checkout multi-module npm install
there is a file to list modules that can be multiples
modules_list.txt
one module name per line
@lavolp3 this implements the 'label' field , which the user can change to anything they want. default is 'instance n' where n is the order of appearance, 1 = first, etc there is a tab in the positioning section to match if u edit the label, it changes the tab label
this label will be persistent
if all the instances are disabled, then the module shows as disabled, otherwise enabled...
i thought of some tricky half/half shading or hatched text for partial.. later
due to the CSS rules, the instance header currently shows as dark grey.. got to figure that out..
1 known issue..
if u add or delete an instance, the tab below in positions doesn't delete or add..
pushed latest, form generation supporting multiple instances... still no saving yet still known issue
1 known issue.. resolved
if u add or delete an instance, the tab below in positions DOES add or delete.
promoted as only version
MMM-Carousel and MMM-Pages support other modules w multiple instances running. also MMM-FaceReco-dnn