search

sdetweil / MagicMirror_scripts

Magic Mirror installation and setup scripts
337 stars 61 forks source link

Improve Node and Git running check #86

Open alucard856 opened 3 months ago

alucard856 commented 3 months ago

This means that fewer additional grep forks are created.

sdetweil commented 3 months ago

what platforms did you test this on?

alucard856 commented 3 months ago

I run Buster with Bash 5.0.3. Bullseye and Bookworm also run with it because they have a newer Bash. Unfortunately I can't test Apple because I don't have MacOS.

OS: Raspbian GNU/Linux 10 (buster) armv7l Host: Raspberry Pi 3 Model B Rev 1.2 Kernel: 5.10.103-v7+ Shell: bash 5.0.3

sdetweil commented 3 months ago

thanks. because of the number of platforms, I have tried not to use any regex operators

what problem made you look at this?

alucard856 commented 3 months ago

In principle, it is only more resource-efficient and requires less CPU and RAM. If the focus is on little to no regex, the other solution is better. I just had a look at the script and saw an improvement. This does not solve a problem.

sdetweil commented 3 months ago

thanks for the feedback. I generally agree on less resource, but if the target cannot run simple pipe then running MagicMirror will be doomed