sdevih / pe

0 stars 0 forks source link

History feature shows the wrong error message #2

Open sdevih opened 7 months ago

sdevih commented 7 months ago

Description

Command history feature is said to re-run commands based on the specified index, but when a delete command is re-run, the index in the error message shown does not refer to that in the command history index but of the student list. This may be confusing to read as the error message does not match the error (given that the user cannot see the current student list) and thus, this behaviour is not specified and differs from normal expectations.

Steps to reproduce

  1. list
  2. delete 8
  3. history
  4. history 3

Expected

Actual

Screenshot

image.png

nus-pe-script commented 6 months ago

Team's Response

Thanks for raising this issue! While the output does seem to be giving out the correct output given that it outputs "student index", it probably will cause quite a bit of confusion for users. The output delete command in this case, wasn't made clear enough to distinguish between the student list and the command list.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]