search

sdfordham / pysyncon

A python module for the synthetic control method
MIT License
41 stars 9 forks source link

AugSynth Predictor Optimization & P-Value Fixes #67

Open LukasHaas opened 1 month ago

LukasHaas commented 1 month ago

Augsynth was not using other predictors besides the outcome variable in the weights optimization. The ridge regression is not enough to adjust the weights based on other (or special) predictors. Including the predictors in the initial weights optimization ensures the treatment and synthetic variable is almost equal in all predictors in the pre-treatment period, where possible.

sdfordham commented 1 month ago

I'm not sure I follow the change to p-value can you explain? And actually, the existing code does match the formula for permutation p-value in Firpo and Possebom's paper (eq. 5 of the published one).