search

sdgathman / pyspf

Other
49 stars 26 forks source link

PEP8 coding style #38

Open aernan opened 2 years ago

aernan commented 2 years ago

I would like to contribute to this project by making the code PEP8 compliant: https://www.python.org/dev/peps/pep-0008/

I have never contributed to an open source project before so I'm hoping this is the right place to post and simple thing to start on.

sdgathman commented 2 years ago

This is the right place to post. It is fairly simple. But it generates a lot of changes - which makes it difficult to review. For starters, you will need to use this list of PEP8 requirements that are deliberately not met:

Check   Description             Justification
E111    req indent 4            Creates more continuation lines
E114    req indent 4 cmnt       Same
E231    req space after ,       makes calls like print() harder to read
E266    no ##                   Required by Doxygen
W291    trailing spaces in cmnt Needed for space preserving para reformat

I will push these as pep8.dat, and we'll see what it looks like then

sdgathman commented 2 years ago

https://github.com/sdgathman/pyspf/commit/0b985f9692d7ae305774913e67ed639240e237e7 adds the exception list.