sdglhm / dompdf

Automatically exported from code.google.com/p/dompdf
0 stars 0 forks source link

Vertical align issue with nested table not working #406

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a html file with two tables, one table nested in the td of the other.
2. Make the height of td (in which the 2nd table is nested) 200px and apply 
style vertical-align as middle. Put in background colors of the td and nested 
table to view the output better.
3. Render the page using dompdf.

What is the expected output? What do you see instead?
Instead of seeing the nested table center aligned, the nested table is top 
aligned even though it seems dompdf is 'trying' to render it in the middle as 
per the vertical-align property.

What version of dompdf are you using? What version of PHP? On what
operating system?
This happens on 0.6 beta 2.

Please provide the HTML source code you want to convert, or any additional 
information.

HTML file and other screenshots are attached below. The yellow color in the 
middle (screenshot dompdf_render1.jpg) is 'dompdf' trying to render the nested 
table in the middle but the nested table text is showing on top!

Original issue reported on code.google.com by prabal....@gmail.com on 13 Jan 2012 at 2:34

Attachments:

GoogleCodeExporter commented 9 years ago
Perhaps a line box problem. Fabien?

Original comment by eclecticgeek on 14 Jan 2012 at 2:59

GoogleCodeExporter commented 9 years ago
I confirm this issue, but I don't think this is related to the line box. It may 
be due to the way frames are moved when vertically centered. Here the table is 
moved to the middle, but not the cells. I already noticed this issue, but 
didn't fix it.

Original comment by fabien.menager on 14 Jan 2012 at 1:50

GoogleCodeExporter commented 9 years ago
I commited a fix for this, can you confirm it works well for you ?

Original comment by fabien.menager on 14 Jan 2012 at 2:57

GoogleCodeExporter commented 9 years ago
The changes appear to address the test case provided.

Original comment by eclecticgeek on 15 Jan 2012 at 2:54

GoogleCodeExporter commented 9 years ago
Hi Fabien,

Do I have to do a complete checkout for the svn for this fix or can I just 
download a few files and get this done?

Thanks.

Original comment by prabal....@gmail.com on 15 Jan 2012 at 12:20

GoogleCodeExporter commented 9 years ago
I recommend you to do a checkout or download the nightly from here : 
http://eclecticgeek.com/dompdf/

Original comment by fabien.menager on 15 Jan 2012 at 1:14

GoogleCodeExporter commented 9 years ago
Thanks. This works perfectly now.

Original comment by prabal....@gmail.com on 17 Jan 2012 at 1:52

GoogleCodeExporter commented 9 years ago

Original comment by fabien.menager on 17 Jan 2012 at 10:15

GoogleCodeExporter commented 9 years ago

Original comment by eclecticgeek on 30 May 2013 at 5:16