Haddock failure on master with GHC 8.4

sdiehl / repline

Haskeline wrapper for GHCi-like REPL interfaces

MIT License

107 stars 28 forks source link

Haddock failure on master with GHC 8.4 #31

Closed sjakobi closed 4 years ago

sjakobi commented 4 years ago

$ cabal haddock -w ghc-8.4.4
...
src/System/Console/Repline.hs:247:3: error:
    parse error on input ‘-- | banner function’
    |
247 |   -- | banner function
    |   ^^^^^^^^^^^^^^^^^^^^

@basile-henry mentioned this in https://github.com/dhall-lang/dhall-haskell/pull/1867/files#r441794458.

I'd recommend checking haddock-compatibility in CI BTW.

sdiehl commented 4 years ago

Fixed in 7bcff62

basile-henry commented 4 years ago

This issue is back in the release! I think it's a problem with the way Ormolu formats function types which is incompatible with GHC 8.4 haddock parser. :cry:

sdiehl commented 4 years ago

Like they say in the ormolu thread, it builds fine on recent versions of GHC so this seems low priority. If you want to submit a patch for the Haddock I'd be happy to merge it, if it's compatible with every Haddock parser.

adamwespiser commented 2 years ago

This is coming up, again, when we try to build the documentation for this project using ghc 8.2 and 8.4. I don't think it's worth updating haddock for those versions, and my tendency is to drop official support for ghc 8.2/8.4 for repline.

sjakobi commented 2 years ago

Sounds good to me! :+1: