search

sdiehl / write-you-a-haskell

Building a modern functional compiler from first principles. (http://dev.stephendiehl.com/fun/)
MIT License
3.34k stars 256 forks source link

more changes #46

Closed chsievers closed 9 years ago

chsievers commented 9 years ago

Some proposed changes to the first four chapters and the accompanying code.

Please also have a look at my 'remarks' branch where I marked lines that I felt might be improved without having concrete suggestions. I plan to continue committing remarks to that branch, so you might want to track it.

sdiehl commented 9 years ago

Thanks again, I made a few minor nits, but I think I can merge this pretty quick so long as I understand what the changes to the option function involved. Was there a bug?

chsievers commented 9 years ago

Don't know about option, but (<|>) didn't seem to satisfy its specification.