search

sdiehl / write-you-a-haskell

Building a modern functional compiler from first principles. (http://dev.stephendiehl.com/fun/)
MIT License
3.34k stars 256 forks source link

Untyped chapter has out of order material #8

Closed reinh closed 9 years ago

reinh commented 9 years ago

Stephen, wonderful work here!

The Untyped chapter includes a section on pretty printing but some of the material relating to pretty printing appears earlier, at the end of the Reduction section, and seems out of order.

sdiehl commented 9 years ago

Indeed, the pretty printer section wasn't moved properly.

sdiehl commented 9 years ago

I reflowed the section on the Untyped Lambda Calculus, hopefully it makes more sense now.

https://github.com/sdiehl/write-you-a-haskell/blob/master/lambda_calculus.md

reinh commented 9 years ago

Unfortunately, the phrase "The p variable will indicate our depth within the current structure" is now somewhat confusing as p seems to refer to "class Pretty p where".

I've submitted #15 to address this. Please feel free to use all, some, or none of my changes.