search

sdimkov / hubot-skype-web

A Skype adapter for Hubot that connects via Skype web.
MIT License
45 stars 16 forks source link

Fix pollRequest TypeError: Cannot read property 'length' of undefined #1

Closed nagodon closed 9 years ago

nagodon commented 9 years ago

Hi @sdimkov

This PR is the error handling of the response of pollRequest

Before:

[Tue Sep 01 2015 02:21:18 GMT+0900 (JST)] ERROR Parsing poll results failed: TypeError: Cannot read property 'length' of undefined

After:

[Tue Sep 01 2015 20:42:12 GMT+0900 (JST)] ERROR Parsing poll results failed: Error: empty response
[Tue Sep 01 2015 20:13:17 GMT+0900 (JST)] ERROR Parsing poll results failed: Error: You must create an endpoint before performing this operation.
sdimkov commented 9 years ago

@nagodon Thanks for the PR!

I actually have something similar locally for handling the problematic polls. I'll try to push it later today.

nagodon commented 9 years ago

@sdimkov

It's ok. Close this PR.