search

sdinteractive / Magento2_SomethingDigital_UpgradeHelper

18 stars 23 forks source link

Use the framework for checking for template overrides #5

Closed mpchadwick closed 3 years ago

mpchadwick commented 6 years ago

Right now we use the ugly shell_exec of the find command to determine if template files are overridden. There's probably a better way to do this (likely leveraging a class under Magento\Framework\View...)

mpchadwick commented 4 years ago

This is worth looking into, but need to be careful as it also seems like it could be prohibitively slow if not done correctly.

mpchadwick commented 3 years ago

Going to close this for now, given that #38 drastically improved override checking.