search

sdispater / clikit

CliKit is a group of utilities to build beautiful and testable command line interfaces.
MIT License
72 stars 17 forks source link

Add support for ContextManager type pre 3.5.4 #8

Closed cole closed 4 years ago

cole commented 4 years ago

ContextManager was added to typing in 3.5.4, so on 3.5.2 it fails to import. typing-extensions provides a backport.

Fixes https://github.com/sdispater/clikit/issues/7.

ocavue commented 4 years ago

@sdispater Could you please take some time to review this PR? This PR fix the ImportError in ubuntu 16.04's python (3.5.2), which is stopping us from using poetry.

Related issues:

BTW, this PR dosen't actually break the CI. @cole did not modify those files black complain about.

rvanlaar commented 4 years ago

What is needed to get this PullRequest to be accepted?

sdispater commented 4 years ago

Could you rebase your branch onto the latest master?

rvanlaar commented 4 years ago

@cole Could you rebase this on master? I could do it later today if necessary. It would mean a new pull request though.

cole commented 4 years ago

@sdispater @rvanlaar rebased.

rvanlaar commented 4 years ago

It seems the issue was fixed.

What's the status for this issue? Can I help move this forward?