Default error style is hard to read with solarized theme

[blueyed]

The default error style is rather hard to read for me (using a solarized terminal theme):

It becomes better when using "bold":

The color palette (non-bold white is rather greyish):

It also looks bad with the light solarized variant:

I suggest changing the default to be just bold red (fg).

Came here via cleo, which uses this (with additional empty lines around it to create a box):

Changing the default itself might require changes downstream though, as can be seen with poetry's error (which uses bg=red inline):

So regarding this it seems to be better to change the default to fg=red only, and then poetry would use bold or another option to highlight the destination.

However, "<fg=red>Something <options=bold>filename</> else.</> does not work as I would expect it: filename is not red, i.e. options are not added, but reset when nested?!

[sdispater]

Thanks for taking the time to write a detailed issue.

However, I won't change the style, unfortunately for you.

The thing is, if I put it in bold white it might not suit someone with another color theme that would define bold white to something not white. So, pastel can't support the thousands of color themes out there.

Regarding the formatting of errors, I won't change it since I like it this way: the error is isolated from the rest so easier to notice at a glance and having the type of the error separated from the error message is cleaner in my opinion.

[blueyed]

Uhm, that's a bummer. I wasn't suggesting to use bold white on red, but rather just (bold) red on default bg - that would be the most portable, and certainly makes sense for a library.

You could then still use a more "fancy" style in poetry itself.

As for poetry's error boxes: even when they are readable they take a lot of unnecessary space IMHO.