Restore period function with deprecation warning

sdispater / pendulum

Python datetimes made easy

https://pendulum.eustace.io

MIT License

6.12k stars 372 forks source link

Restore period function with deprecation warning #786

Open mathieulongtin opened 6 months ago

mathieulongtin commented 6 months ago

Pull Request Check List

[ ] Added tests for changed code.
[ ] Updated documentation for changed code.

Secrus commented 6 months ago

Why? This was an intentional breaking change followed by a major version bump. I don't see any reason to bring this back.

mathieulongtin commented 6 months ago

Why? This was an intentional breaking change followed by a major version bump. I don't see any reason to bring this back.

We’ve been using pendulum for five year or so. It’s solid, it works, it fixes gaps in the datetime library.

But changing a function name with no depreciation warning after years with the old name is not cool. Major version change or not. Now we have to worry about dependency mismatches, and wonder if other naming changes will be sprung on us.