search

sdkman / homebrew-tap

Apache License 2.0
34 stars 5 forks source link

apply changes to the bash profile and zsh profile #2

Open pjungermann opened 1 year ago

pjungermann commented 1 year ago

Compared to https://get.sdkman.io/ the brew formula does not add anything to the bash or zsh profile. This only mentioned here at the README.md.

I didn't notice it even as hint / caveat when running

brew install sdkman-cli

I think, it would be great if no further manual action is necessary after running the install command.

helpermethod commented 1 year ago

The problem is that Homebrew discourages changing files outside of Homebrew (it is actually only possible by using some very ugly hacks).

So the best thing we could do is display a message after installation to add the necessary line(s) to Bash/zsh profile. Which btw is also discouraged, bc according to Homebrew this should the part of the documentation.