search

sdkman / sdkman-action

SDKMAN! GitHub Action
21 stars 7 forks source link

Default post-install hook #9

Open jayvdb opened 3 years ago

jayvdb commented 3 years ago

When I install kscript via sdkman on Windows, I can invoke kscript after I do source "$HOME/.sdkman/bin/sdkman-init.sh"

When using this action, a .zip is dropped into the current directory, and nothing more is done. https://api.sdkman.io/2/hooks/post/kscript/3.1.0/linux and https://api.sdkman.io/2/hooks/post/kscript/3.1.0/windows have no post-install hook.

I didnt see anything in https://github.com/search?q=org%3Asdkman+kscript&type=code which defines kscript, so I am at a bit of a loss for how sdkman knows how to handle each candidate.

I am guessing the real sdkman has some voodoo which unzips, recognises the bin/ inside, and makes the .jar executable.

It would be great if this github action could replicate the sdk commands post-install voodoo.

Alternatively, could this github action install the sdk cli.

eddumelendez commented 2 years ago

Hi @jayvdb

Thanks for the report, it was an initial experimentation on this action. I am working on #11 which is actually using sdkman but is not running on windows. I just started this today so maybe a little bit more of research on my side to make it available on all OS. Also, look that for java I need actions/setup-java, I think with this new approach you will be able to run sdk