search

sdkman / sdkman-candidates

The Candidates service that under-girds SDKMAN! CLI.
Other
10 stars 15 forks source link

Bug: sdk list java does not show Eclipse Adoptium / AdoptOpenJDK JDKs #40

Closed az82 closed 3 years ago

az82 commented 3 years ago

Bug report

sdk list java with SDKMAN 5.12.4 on macOs Big Sur does not show the Eclipse Adoptium / AdoptOpenJDK JDKs. Even installed JDKs are not shown.

Output of sdk list java:

~ ❯ sdk list java | cat                                                                                                                                                                                                                                                      4s
================================================================================
Available Java Versions
================================================================================
 Vendor        | Use | Version      | Dist    | Status     | Identifier
--------------------------------------------------------------------------------
 Corretto      |     | 17.0.0.35.2  | amzn    |            | 17.0.0.35.2-amzn
               |     | 17.0.0.35.1  | amzn    |            | 17.0.0.35.1-amzn
               |     | 16.0.2.7.1   | amzn    |            | 16.0.2.7.1-amzn
               |     | 11.0.12.7.2  | amzn    |            | 11.0.12.7.2-amzn
               |     | 8.302.08.1   | amzn    |            | 8.302.08.1-amzn
 GraalVM       |     | 21.2.0.r16   | grl     |            | 21.2.0.r16-grl
               |     | 21.2.0.r11   | grl     |            | 21.2.0.r11-grl
               |     | 20.3.3.r11   | grl     |            | 20.3.3.r11-grl
               |     | 19.3.6.r11   | grl     |            | 19.3.6.r11-grl
 Java.net      |     | 18.ea.15     | open    |            | 18.ea.15-open
               |     | 18.ea.2.lm   | open    |            | 18.ea.2.lm-open
               |     | 17           | open    |            | 17-open
               |     | 17.ea.3.pma  | open    |            | 17.ea.3.pma-open
               |     | 16.0.2       | open    |            | 16.0.2-open
               |     | 11.0.2       | open    |            | 11.0.2-open
 Liberica      |     | 17.0.0.fx    | librca  |            | 17.0.0.fx-librca
               |     | 17.0.0       | librca  |            | 17.0.0-librca
               |     | 16.0.2.fx    | librca  |            | 16.0.2.fx-librca
               |     | 16.0.2       | librca  |            | 16.0.2-librca
               |     | 11.0.12.fx   | librca  |            | 11.0.12.fx-librca
               |     | 11.0.12      | librca  |            | 11.0.12-librca
               |     | 8.0.302.fx   | librca  |            | 8.0.302.fx-librca
               |     | 8.0.302      | librca  |            | 8.0.302-librca
 Liberica NIK  |     | 21.2         | nik     |            | 21.2-nik
 Microsoft     |     | 16.0.2.7.1   | ms      |            | 16.0.2.7.1-ms
               |     | 11.0.12.7.1  | ms      |            | 11.0.12.7.1-ms
 SapMachine    |     | 17           | sapmchn |            | 17-sapmchn
               |     | 16.0.2       | sapmchn |            | 16.0.2-sapmchn
               |     | 11.0.12      | sapmchn |            | 11.0.12-sapmchn
 Semeru        |     | 16.0.2       | sem     |            | 16.0.2-sem
               |     | 11.0.12      | sem     |            | 11.0.12-sem
               |     | 8.0.302      | sem     |            | 8.0.302-sem
 Temurin       |     | 16.0.2       | tem     |            | 16.0.2-tem
               |     | 11.0.12      | tem     |            | 11.0.12-tem
               |     | 8.0.302      | tem     |            | 8.0.302-tem
 Trava         |     | 11.0.9       | trava   |            | 11.0.9-trava
               |     | 8.0.232      | trava   |            | 8.0.232-trava
 Zulu          |     | 17.0.0       | zulu    |            | 17.0.0-zulu
               |     | 17.0.0.fx    | zulu    |            | 17.0.0.fx-zulu
               |     | 16.0.2       | zulu    |            | 16.0.2-zulu
               |     | 16.0.2.fx    | zulu    |            | 16.0.2.fx-zulu
               |     | 11.0.12      | zulu    |            | 11.0.12-zulu
               |     | 11.0.12.fx   | zulu    |            | 11.0.12.fx-zulu
               |     | 8.0.302      | zulu    |            | 8.0.302-zulu
               |     | 8.0.302.fx   | zulu    |            | 8.0.302.fx-zulu
               |     | 7.0.312      | zulu    |            | 7.0.312-zulu
================================================================================
Use the Identifier for installation:

    $ sdk install java 11.0.3.hs-adpt
================================================================================

Installed JDKS:

~ ❯ ls -1 .sdkman/candidates/java
8.0.292.hs-adpt/
11.0.11.hs-adpt/
16.0.1.hs-adpt/
current -> 16.0.1.hs-adpt/

To reproduce

Run sdk list java with SDKMAN 5.12.4 on macOs Big Sur

System info

ratepay-sstein commented 3 years ago

Same issue on Ubuntu with SDKMAN 5.12.4.

rubensa commented 3 years ago

Looks like the "old" AdoptOpenJDK is now the Temurin from Adoptium since the project is now under the Eclipse umbrella. See: https://blog.adoptopenjdk.net/2021/08/goodbye-adoptopenjdk-hello-adoptium/

az82 commented 3 years ago

I was not aware of the Temurin name, sorry for wasting everyones time. Anyway, SDKMAN should still show JDKs that are already installed.

mackatozis commented 3 years ago

There should have been a smoother transition.

I believe that the sdkman should give you the following options:

  1. as @az82 mentioned, sdkman should show the JDKs that are currently installed on the system
  2. give an option to rename the existing AdoptOpenJDK installations from -adpt to -tem
ratepay-sstein commented 3 years ago

Also, homepage needs to be updated: https://sdkman.io/jdks#AdoptOpenJDK

marc0der commented 3 years ago

@eddumelendez it seems like we might have a bug on our hands, as the versions of -adpt are no longer showing, even though they are still installed locally. I'd still expect to see them under the AdoptOpenJDK section on the Java list view.

@az82 thank you for reporting this, we'll definitely take a peek into this and try to get this resolved soon.

@mackatozis the software and the service we provide is free for everyone to use but comes with zero guarantees, as is stipulated in the Apache 2.0 licence that it is distributed under.

@ratepay-sstein thanks for this, I opened an issue on the website yesterday and will push changes to fix the JDKs page soon :+1:

marc0der commented 3 years ago

I've done some digging this morning and have found the issue.

@eddumelendez We only include vendors who have visible versions available. The short term solution would be to keep all the latest AdoptOpenJDK versions visible until we can roll out a fix for this.

eddumelendez commented 3 years ago

@marc0der that's interesting, well, it has been our first time doing so. AdoptOpenJDK has been restore.

az82 commented 3 years ago

Works for me, sdk list now shows the installed jdks again. Thanks!

ratepay-sstein commented 3 years ago

Wow, that was fast. I confirm that it works on Ubuntu, too!

helpermethod commented 3 years ago

We should probably announce this on Twitter. My timeline is full of people asking where the hell AdoptOpenJDK went 😄 .

marc0der commented 3 years ago

I'll write the blog post tonight as well as update the website. Apologies for my tardiness but I'm away on holiday at the moment.

helpermethod commented 3 years ago

Enjoy your holiday!

marc0der commented 3 years ago

The blog post has been written, so this should clarify things for everyone.

Sorry for bouncing this issue around, but it should be moved to the sdkman-candidates project where the changes are to be made.

asfernandes commented 3 years ago

Temurin 17 is already released for main platforms. When will it appear in sdkman?

Edit: sorry for the impatience :)

eddumelendez commented 3 years ago

@asfernandes Eclipse Temurin For Java 17 is available now on sdkman!

marc0der commented 3 years ago

Temurin 17.0.0 is now the new default version for Java on SDKMAN! :tada: