search

sdkman / sdkman-candidates

The Candidates service that under-girds SDKMAN! CLI.
Other
10 stars 15 forks source link

Add Tencent Kona JDKs #46

Closed johnshajiang closed 1 year ago

johnshajiang commented 2 years ago

Tencent Kona JDK is a downstream of OpenJDK. It has three releases: [8], [11] and [17].

[8]: https://github.com/Tencent/TencentKona-8

[11]: https://github.com/Tencent/TencentKona-11

[17]: https://github.com/Tencent/TencentKona-17

eddumelendez commented 2 years ago

After merging it, something like this should be submitted https://github.com/sdkman/sdkman-disco-integration/commit/330b624ba9357cd451825fdb38e40c623780db03

johnshajiang commented 2 years ago

@eddumelendez Thanks for your review very much!

I just submitted a sdkman-disco-integration PR, exactly sdkman/sdkman-disco-integration/pull/4.

eddumelendez commented 2 years ago

@johnshajiang take a look at my suggestion.

johnshajiang commented 2 years ago

@eddumelendez Thanks for approving my PR on sdkman-disco-integration very much.

With your suggestions, I submitted that sdkman-disco-integration PR. After the two PRs are merged, any more works should I do?

johnshajiang commented 1 year ago

@helpermethod @marc0der Could you please review this PR?

johnshajiang commented 1 year ago

Hi, Should this patch be merged? Or what other jobs I should do?

Thanks in advance for any suggestion!

marc0der commented 1 year ago

I've fixed all issues and merged them into master. GH is not picking it up after rebase, so closing this PR.

johnshajiang commented 1 year ago

@marc0der Thanks very much for fixing the issues and push the changes!

johnshajiang commented 1 year ago

@marc0der In addition, could you please take a look another PR on the same JDK distribution? https://github.com/sdkman/sdkman-disco-integration/pull/4