search

sdkman / sdkman-cli

The SDKMAN! Command Line Interface
https://sdkman.io
Apache License 2.0
6.08k stars 629 forks source link

Add missing quotes when handling file paths within install command #1209

Closed kr5ture closed 1 year ago

kr5ture commented 1 year ago

This PR resolves issues when SDKMAN_DIR has whitespaces (see https://github.com/sdkman/sdkman-cli/issues/1208).

kr5ture commented 1 year ago

Wanted to add test case for such scenario but I'm not sure whether I'm able to do so. As far as I can see every test extends from SdkmanEnvSpecification which setup sections sets sdkmanBaseDirectory using static method prepareBaseDir() and then rest of the setup section relies on it 🤔