search

sdkman / sdkman-cli

The SDKMAN! Command Line Interface
https://sdkman.io
Apache License 2.0
6.08k stars 629 forks source link

fix: Quote `$SDKMAN_DIR` in version subcommand #1245

Closed hyperupcall closed 12 months ago

hyperupcall commented 12 months ago

With this change, the version subcommand now works if $SDKMAN_DIR includes newlines, etc.

marc0der commented 12 months ago

Hi @hyperupcall, the version subcommand has been obsolete for a long time and is replaced by the Rust equivalent over here: https://github.com/sdkman/sdkman-cli-native/blob/master/src/bin/version/main.rs

If you are having issues with the version command, please have a conversation with us on Slack so we can raise an issue to fix it properly.

hyperupcall commented 12 months ago

Thank you for your quick response! I see, the equivalent Rust code is always ran instead (assuming they use the installer and are on one of sdkman-cli-native's 5 supported architectures). In that case, I will close this issue since it doesn't actually change anythig. Maybe there can be a comment at the top or the file can be deleted to prevent confusions like this in the future

marc0der commented 12 months ago

No probs, and do let me know if you have any issues. We'll probably begin removing these legacy files soon, but I'll update the project README with some more details.