sdkman / sdkman-cli

The SDKMAN! Command Line Interface
https://sdkman.io
Apache License 2.0
6.08k stars 629 forks source link

Improvement: Verify that `tar` is available #1267

Closed gunnarmorling closed 8 months ago

gunnarmorling commented 8 months ago

I just tried to use SDKMan on a fresh Linux install, and it would keep failing on me with this message:

Download has failed, aborting!

Enabling debug logging didn't provide any further insight about the cause. Only when inspecting the post-install hook, I realized that the issue was that the tar command wasn't available on this environment yet.

marc0der commented 8 months ago

Ah, good catch! That's because tar is only used in the installation hooks, not in the CLI. I'd be happy to have it added it to the install script as a pre-requisite. If you feel up to it, you could even contribute that change yourself over here: https://github.com/sdkman/sdkman-hooks/blob/master/app/views/includes/sanity.scala.txt

gunnarmorling commented 8 months ago

Sure thing: https://github.com/sdkman/sdkman-hooks/pull/62